Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change npm init commands for npx #212

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: change npm init commands for npx #212

merged 1 commit into from
Dec 11, 2024
+7 −7

Conversation

erickzhao
Copy link
Member

Fixes electron/forge#3662

I'm not sure why npm init isn't passing flags into Windows, but this alternative syntax is working for me on macOS at least. Will need someone else to test on Windows today.

felixrieseberg
felixrieseberg approved these changes Dec 11, 2024
View reviewed changes
Copy link

@felixrieseberg felixrieseberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that your new commands work for me on Windows 11 (10.0.22631.0).

Node v22.12.0
npm 10.9.0

@erickzhao erickzhao merged commit 2509154 into v6 Dec 11, 2024
5 checks passed
@erickzhao erickzhao deleted the npx branch December 11, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrieseberg felixrieseberg felixrieseberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm init for templates broken on Windows
2 participants
@erickzhao @felixrieseberg